Github user mpjlu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15647#discussion_r85311930
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/feature/ChiSqSelector.scala ---
    @@ -171,18 +171,19 @@ object ChiSqSelectorModel extends 
Loader[ChiSqSelectorModel] {
     
     /**
      * Creates a ChiSquared feature selector.
    - * The selector supports three selection methods: `kbest`, `percentile` 
and `fpr`.
    - * `kbest` chooses the `k` top features according to a chi-squared test.
    - * `percentile` is similar but chooses a fraction of all features instead 
of a fixed number.
    - * `fpr` chooses all features whose false positive rate meets some 
threshold.
    - * By default, the selection method is `kbest`, the default number of top 
features is 50.
    + * The selector supports different selection methods: `numTopFeatures`, 
`percentile`, `fpr`.
    + *  - `numTopFeatures` chooses the `k` top features according to a 
chi-squared test.
    --- End diff --
    
    ditto


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to