Github user mpjlu commented on a diff in the pull request:
https://github.com/apache/spark/pull/15647#discussion_r85311677
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -44,67 +44,78 @@ private[feature] trait ChiSqSelectorParams extends
Params
/**
* Number of features that selector will select (ordered by statistic
value descending). If the
* number of features is less than numTopFeatures, then this will select
all features.
- * Only applicable when selectorType = "kbest".
+ * Only applicable when selectorType = "numTopFeatures".
* The default value of numTopFeatures is 50.
*
* @group param
*/
+ @Since("1.6.0")
final val numTopFeatures = new IntParam(this, "numTopFeatures",
"Number of features that selector will select, ordered by statistics
value descending. If the" +
" number of features is < numTopFeatures, then this will select all
features.",
ParamValidators.gtEq(1))
setDefault(numTopFeatures -> 50)
/** @group getParam */
+ @Since("1.6.0")
def getNumTopFeatures: Int = $(numTopFeatures)
/**
* Percentile of features that selector will select, ordered by
statistics value descending.
* Only applicable when selectorType = "percentile".
* Default value is 0.1.
+ * @group param
*/
+ @Since("2.1.0")
final val percentile = new DoubleParam(this, "percentile",
"Percentile of features that selector will select, ordered by
statistics value descending.",
--- End diff --
ordered by pValue ascending.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
