Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/2155#discussion_r16877343
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala
---
@@ -50,7 +50,7 @@ abstract class QueryPlan[PlanType <: TreeNode[PlanType]]
extends TreeNode[PlanTy
@inline def transformExpressionDown(e: Expression) = {
val newE = e.transformDown(rule)
- if (newE.id != e.id && newE != e) {
+ if (newE != e) {
--- End diff --
Add back in an `eq` check to avoid the expensive equality checking when the
same object is returned.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
