Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15677
Since this PR is 2000+ line changes, I am unable to quickly go over all of
them. Normally, creating such a big PR is not welcomed, because it is hard for
reviewers to read throught all the changes.
I hope my comments can trigger you to think more and fix all the related
issues, instead of pointing them out by me one by one.
For example, my most recent comment is about the complex type support. Have
you tried the nested types?
BTW, when my teammates do anything like this PR, I always tell them to
write test cases if they are not 100% sure. Do not submit a PR without
verification. I hope we can do the document changes more carefully, because the
external users will not read the source codes. They might easily lose patience.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
