Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/15677
Hey @gatorsmile, I am not rushing to review and also I didn't mean to find
every one. I meant I can wait for all the reviews and then sweep it if they are
only minors and each does not block each other.
As I said, for testing, I have tested one by one when I was in doubt. I
have tested most of them (I admit it wasn't all for every type). So, I guess
mostly the argument types were correct. The recent changes include minor
changes such as `except map`.
In the case of this PR, basically, it introduces new sections in
documentation. I guess fixing the same instances in single PR is reasonable. At
least, I asked @rxin and @srowen first before/after making this PR. I also said
several times this would be big and I guess I got approved.
There are always rooms for improvements for changes. We can't make
something perfect at once. Also, I guess we have still a lot time to fix them
more. For example, we can add all the test cases in a folllowup. This would
even not be released right after this PR. Other guys still can take a look for
this and submit another PR.
Please let us just focus on this topic.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
