Github user srowen commented on the issue:
https://github.com/apache/spark/pull/15677
@gatorsmile yes, this is why I suggested earlier that we stop and commit
the changes we had in the last PR. We have to break this up to make it
manageable in this case, because of the size. There are important doc fixes
here that we do need to commit. You have indeed asked for a different
additional set of logical changes, and now we're mostly down that path, which
has led to one big bang PR. I don't think it's useful to question now whether
it should be committed!
We can commit a change that is a coherent improvement, which does not make
the docs worse. We do not have to commit a change that improves or even fixes
everything in the existing docs. Some of the problems you're highlighting were
there already. Some are improvements to new docs, where there was simply no
information before.
Re-skimming this large change, it seems like it makes a coherent
improvement to the docs (modulo a few more fixes you suggested). If the issue
is down to type info, do you believe anything here is actually wrong-er than it
was before? If so, let's zero in on those essential changes and make them, and
merge this. If not let's merge this. If there is more to discuss, it will be
much easier to address in a second pass, I think. We won't have a release in
between the two PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
