Github user gatorsmile commented on the issue:
https://github.com/apache/spark/pull/15677
Based on my review in this PR, I think we need to resolve the following
three major issues when we document the argument type:
- First, implicit type casting should be clearly explained when we document
the argument types. I am not comfortable if we just let external users figure
it out by themselves. They do not know the rules.
- Second, null handling of function arguments should also be documented.
For most function arguments, it is null intolerant. However, we still have a
few exceptions. For example, `sentences`.
- Third, the arguments also need to use different terms for
`literal`/`constant`, `foldable expressions` and `non-foldable expressions`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
