Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/15677#discussion_r85644253
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -148,8 +171,15 @@ case class Hour(child: Expression) extends
UnaryExpression with ImplicitCastInpu
}
@ExpressionDescription(
- usage = "_FUNC_(param) - Returns the minute component of the
string/timestamp/interval.",
- extended = "> SELECT _FUNC_('2009-07-30 12:58:59');\n 58")
+ usage = "_FUNC_(timestamp) - Returns the minute component of the
string/timestamp.",
+ extended = """
+ Arguments:
+ timestamp - a timestamp expression.
--- End diff --
In DBMS, this is a very common issue. If users want to use strings to
represent timestamp, or the other datetime values, they need to follow the
formats. If I were users, my first question is which formats they should
follow. For example, the precision is 6 or 2?
`string/timestamp` is not clear. We definitely should improve it. Below is
a document you can refer:
http://www.ibm.com/support/knowledgecenter/SSEPEK_11.0.0/sqlref/src/tpc/db2z_datetimestringrepresentation.html
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
