Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/15677
  
    @gatorsmile, I guess the changes here are roughly correct and accurate and 
make sense. This does not mean "not right" or "wrong". 
    
    For example, if users run `describe function extended reverse;` (the one 
you pointed out right above)
    
    **Before**
    
    ```
    Function: reverse
    Class: org.apache.spark.sql.catalyst.expressions.StringReverse
    Usage: reverse(str) - Returns the reversed given string.
    Extended Usage:
    > SELECT reverse('Spark SQL');
     'LQS krapS'
    ```
    
    **After**
    
    ```
    Function: reverse
    Class: org.apache.spark.sql.catalyst.expressions.StringReverse
    Usage: reverse(str) - Returns the reversed given string.
    Extended Usage:
        Arguments:
          str - a string expression.
    
        Examples:
          > SELECT reverse('Spark SQL');
           LQS krapS
    ```
    
    Do you think this is completely incorrect and what users might easily lose 
patience at? I guess this is an improvement. Sure, we can improve them more and 
make them more correct but I guess this might not be the reason to block this 
change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to