Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/2217#issuecomment-53977801
Hi there,
The immutability of broadcast variables might be assumed in other places in
the code base. Since this approach requires re-broadcasting the entire contents
anyways... why not just create a new broadcast variable? Old ones get cleaned
up now when they go out of scope anyways.
Also, currently this approach will destroy a broadcast variable even if it
is still in scope. For instance, what if the broadcast variable is referenced
on an executor between when `doDestroy` is called and when `putSingle`
succeeds? This could lead to an exception on the executor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
