Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15736#discussion_r89631952
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/PartitionedPairBuffer.scala
---
@@ -74,8 +74,8 @@ private[spark] class PartitionedPairBuffer[K,
V](initialCapacity: Int = 64)
/** Iterate through the data in a given order. For this class this is
not really destructive. */
override def partitionedDestructiveSortedIterator(keyComparator:
Option[Comparator[K]])
: Iterator[((Int, K), V)] = {
- val comparator =
keyComparator.map(partitionKeyComparator).getOrElse(partitionComparator)
- new Sorter(new KVArraySortDataFormat[(Int, K), AnyRef]).sort(data, 0,
curSize, comparator)
+ new Sorter(new KVArraySortDataFormat[(Int, K),
--- End diff --
I think breaking the line here is odd. If necesasry, pull out the result of
`getComparator` to a statement above to shorten this line, like it was before.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
