Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15736#discussion_r89686503
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
---
@@ -75,16 +75,22 @@ private[spark] object WritablePartitionedPairCollection
{
}
/**
- * A comparator for (Int, K) pairs that orders them both by their
partition ID and a key ordering.
+ * Takes an optional parameter (keyComparator), use if provided
+ * and returns a comparator for the partitions
*/
- def partitionKeyComparator[K](keyComparator: Comparator[K]):
Comparator[(Int, K)] = {
- new Comparator[(Int, K)] {
- override def compare(a: (Int, K), b: (Int, K)): Int = {
- val partitionDiff = a._1 - b._1
- if (partitionDiff != 0) {
- partitionDiff
- } else {
- keyComparator.compare(a._2, b._2)
+ def getComparator[K](keyComparator: Option[Comparator[K]]):
Comparator[(Int, K)] = {
+ if (!keyComparator.isDefined) return partitionComparator
--- End diff --
inline and remove partitionComparator, as I think it's not used
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
