Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/15736#discussion_r89632807
--- Diff:
core/src/main/scala/org/apache/spark/util/collection/WritablePartitionedPairCollection.scala
---
@@ -74,6 +74,31 @@ private[spark] object WritablePartitionedPairCollection {
}
}
+ /* Takes an optional parameter (keyComparator), use if provided
+ * and returns a comparator for the partitions
+ */
+ def getComparator[K](keyComparator: Option[Comparator[K]]) :
Comparator[(Int, K)] = {
+ val comparator : Comparator[(Int, K)] =
+ if (keyComparator.isEmpty) {
+ partitionComparator
+ } else {
+ new Comparator[(Int, K)] {
+ // We know we have a non-empty comparator here
+ val ourKeyComp = keyComparator.get
+ override def compare(a: (Int, K), b: (Int, K)): Int = {
+ val partitionDiff = a._1 - b._1
--- End diff --
I'm still not thrilled about the subtraction here but maybe leave it for now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
