Github user ericl commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15998#discussion_r90097773
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/InMemoryCatalog.scala
 ---
    @@ -482,6 +482,19 @@ class InMemoryCatalog(
         }
       }
     
    +  override def listPartitionNames(
    +      db: String,
    +      table: String,
    +      partialSpec: Option[TablePartitionSpec] = None): Seq[String] = 
synchronized {
    +    val partitionColumnNames = getTable(db, table).partitionColumnNames
    +
    +    listPartitions(db, table, partialSpec).map { partition =>
    +      partitionColumnNames.map { name =>
    +        name + "=" + partition.spec(name)
    --- End diff --
    
    Based on manual testing it seems that hive returns escaped values here. So 
for example, if you had a partition with column `B` and value `============`, 
then the hive client returns  `b=%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D%3D`. So this 
code should probably call `getPathFragment` to have the same behavior.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to