Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15998#discussion_r90756432
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveClientImpl.scala 
---
    @@ -519,6 +519,26 @@ private[hive] class HiveClientImpl(
         client.alterPartitions(table, newParts.map { p => toHivePartition(p, 
hiveTable) }.asJava)
       }
     
    +  /**
    +   * Returns the partition names for the given table that match the 
supplied partition spec.
    +   * If no partition spec is specified, all partitions are returned.
    +   *
    +   * The returned sequence is sorted as strings.
    --- End diff --
    
    but according to how we use this API in Spark SQL, we don't need to sort 
right? maybe we can just do the sorting in test.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to