Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15998#discussion_r90181774
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveExternalCatalog.scala ---
    @@ -922,6 +924,25 @@ private[spark] class HiveExternalCatalog(conf: 
SparkConf, hadoopConf: Configurat
       /**
        * Returns the partition names from hive metastore for a given table in 
a database.
        */
    +  override def listPartitionNames(
    +      db: String,
    +      table: String,
    +      partialSpec: Option[TablePartitionSpec] = None): Seq[String] = 
withClient {
    +    val actualPartColNames = getTable(db, table).partitionColumnNames
    +    val clientPartitionNames =
    +      client.getPartitionNames(db, table, 
partialSpec.map(lowerCasePartitionSpec))
    +    clientPartitionNames.map { partName =>
    +      val partSpec = PartitioningUtils.parsePathFragmentAsSeq(partName)
    +      partSpec.map { case (partName, partValue) =>
    +        
escapePathName(actualPartColNames.find(_.equalsIgnoreCase(partName)).get) + "=" 
+
    --- End diff --
    
    can we just build a map with lower cased partition column name as key, and 
path-escaped actual partition column name as value? then we can do a simple map 
lookup here, i.e. `map.get(partName.toLowerCase)`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to