Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15480#discussion_r90441646
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
 ---
    @@ -118,7 +118,42 @@ object GenerateOrdering extends 
CodeGenerator[Seq[SortOrder], Ordering[InternalR
               }
           """
         }.mkString("\n")
    -    comparisons
    +
    +    /*
    +     * 40 = 7000 bytes / 170 (around 170 bytes per ordering comparison).
    --- End diff --
    
    test cases are not real world workloads, we can't estimate comparison code 
size based on test cases. My idea is that, first we generate the comparison 
code like before, and check the code size, if it exceeds 1024(see 
https://github.com/apache/spark/pull/15620#discussion_r90185362), go to the 
splitting branch.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to