Github user ueshin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15480#discussion_r90474669
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
 ---
    @@ -118,7 +118,42 @@ object GenerateOrdering extends 
CodeGenerator[Seq[SortOrder], Ordering[InternalR
               }
           """
         }.mkString("\n")
    -    comparisons
    +
    +    /*
    +     * 40 = 7000 bytes / 170 (around 170 bytes per ordering comparison).
    --- End diff --
    
    I tried to refactor `ctx.splitExpressions()` like 
0aedc47fa94366a39e66da82b70c79dccac7d375 based on @lw-lin's PoC.
    Unfortunately, the max number of comparisons we can support declined to 
around `5000` (current approach can support `10000` or more) because 
`ctx.splitExpressions()` splits comparisons into smaller size than current rule.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to