Github user lw-lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/15480#discussion_r90454770
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -118,7 +118,42 @@ object GenerateOrdering extends
CodeGenerator[Seq[SortOrder], Ordering[InternalR
}
"""
}.mkString("\n")
- comparisons
+
+ /*
+ * 40 = 7000 bytes / 170 (around 170 bytes per ordering comparison).
--- End diff --
thanks @cloud-fan @ueshin for your valuable comments.
@ueshin do you have an on-going work of refactoring
`ctx.splitExpressions()`? If you do, I might update this PR to rely on your
work -- do not want to step on your toes :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
