Github user steveloughran commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16089#discussion_r90499765
  
    --- Diff: 
common/unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
    @@ -147,6 +147,17 @@ public void writeTo(ByteBuffer buffer) {
         buffer.position(pos + numBytes);
       }
     
    +  public void writeTo(OutputStream out) throws IOException {
    --- End diff --
    
    always good to have tests for the corner case codepaths here, as they are 
invariably the official home of off-by-one errors


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to