Github user steveloughran commented on the issue:

    https://github.com/apache/spark/pull/16089
  
    AFAIK, the big thing the FileOutputFormat really adds is not the 
compression, but the output committer and the stuff to go with that (working 
directories, paths, etc etc). If you aren't going near that, and just want a 
fast write of .csv and jackson with optional compression, well, I don't see 
anything in the code I'd run away from.
    
    If you do want to think about how to write CSV files during the output of 
speculative work in the presence of failures, well, that's where the 
mapred.lib.output code really comes out to play.
    
    Otherwise, in general PR review mode: Tests? What if the code asks for a 
committer that isn't there, passes in null sequences in rows to write, tries to 
hit the buffer corner cases. Hopefully those exist already, but if not, now is 
a good time to try to break things.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to