Github user cloud-fan commented on a diff in the pull request: https://github.com/apache/spark/pull/13909#discussion_r91002161 --- Diff: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/ExpressionEvalHelper.scala --- @@ -59,12 +59,36 @@ trait ExpressionEvalHelper extends GeneratorDrivenPropertyChecks { * Check the equality between result of expression and expected value, it will handle * Array[Byte], Spread[Double], and MapData. */ - protected def checkResult(result: Any, expected: Any): Boolean = { + protected def checkResult(result: Any, expected: Any, expr: Any = null): Boolean = { --- End diff -- how about we change this file like this? https://github.com/apache/spark/pull/15645/files#diff-41747ec3f56901eb7bfb95d2a217e94dR59
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org