Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91854780
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +58,15 @@ public BufferHolder(UnsafeRow row, int initialSize) {
this.buffer = new byte[fixedSize + initialSize];
this.row = row;
this.row.pointTo(buffer, buffer.length);
+ this.array = null;
+ }
+
+ public BufferHolder(UnsafeArrayData array, long numElements) {
--- End diff --
I cannot understand what this means.
Current `UnsafeArrayWriter` assumes existence of `BufferHolder`. Do you
want not to allocate `BufferHolder` for this case and refactor
`UnsafeArrayWriter` to support a case without `BufferHolder`?
Or, do you want to remove `numElements`?
Or, do you want to allocate buffer here? This approach introduces
duplication of the same logic here and in `UnsafeArrayWriter`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
