Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91854826
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +58,15 @@ public BufferHolder(UnsafeRow row, int initialSize) {
this.buffer = new byte[fixedSize + initialSize];
this.row = row;
this.row.pointTo(buffer, buffer.length);
+ this.array = null;
+ }
+
+ public BufferHolder(UnsafeArrayData array, long numElements) {
--- End diff --
I do not understand what `this` means.
Do you want not to allocate `BufferHolder` for this case. If so, it
requires to refactor `UnsafeArrayWrite` since the current `UnsafeArrayWrite`
assumes `BufferHolder`.
Or , do you want to eliminate `numElements`?
Or, do you want to allocate `buffer` here? I did not take this approach
since it introduces a duplication of the same logic here and in
`UnsafeArrayWrite`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
