Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91453428
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -468,11 +469,7 @@ object GeneralizedLinearRegression extends
DefaultParamsReadable[GeneralizedLine
override def variance(mu: Double): Double = mu * (1.0 - mu)
private def ylogy(y: Double, mu: Double): Double = {
- if (y == 0) {
- 0.0
- } else {
- y * math.log(y / mu)
- }
+ if (y == 0) 0.0 else y * math.log(y / mu)
--- End diff --
Well the entire thing can go on one line, but only change it if you make
another commit since it's trivial.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
