Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91898659
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -467,10 +469,12 @@ object GeneralizedLinearRegression extends
DefaultParamsReadable[GeneralizedLine
override def variance(mu: Double): Double = mu * (1.0 - mu)
+ private def ylogy(y: Double, mu: Double): Double = {
+ if (y == 0) 0.0 else y * math.log(y / mu)
+ }
+
override def deviance(y: Double, mu: Double, weight: Double): Double =
{
--- End diff --
I would prefer to remove the added method `ylogy`, which is only used in
one place, and replace it with the following logic:
````scala
override def deviance(y: Double, mu: Double, weight: Double): Double = {
val clamped = y.min(1 - epsilon).max(epsilon)
2.0 * weight * (clamped * math.log(clamped / mu) + (1 - clamped) *
math.log((1 - clamped) / (1 - mu)))
}
````
I think it's better to avoid adding a static method that is only used in
one other method, and additionally I think it's clearer what the intent is
here. I'm open to other opinions though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
