Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16149#discussion_r91643515
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/regression/GeneralizedLinearRegressionSuite.scala
---
@@ -715,7 +715,7 @@ class GeneralizedLinearRegressionSuite
val datasetWithWeight = Seq(
Instance(1.0, 1.0, Vectors.dense(0.0, 5.0).toSparse),
Instance(0.5, 2.0, Vectors.dense(1.0, 2.0)),
- Instance(1.0, 3.0, Vectors.dense(2.0, 1.0)),
+ Instance(1.0, 0.3, Vectors.dense(2.0, 1.0)),
--- End diff --
If you mean input weight = 0, then it is better to be tested separately
along with all the other families from the current PR. I think the current test
is good for the current PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
