Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r91856572
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/codegen/BufferHolder.java
---
@@ -55,6 +58,15 @@ public BufferHolder(UnsafeRow row, int initialSize) {
this.buffer = new byte[fixedSize + initialSize];
this.row = row;
this.row.pointTo(buffer, buffer.length);
+ this.array = null;
+ }
+
+ public BufferHolder(UnsafeArrayData array, long numElements) {
--- End diff --
@kiszk We only need to use `BufferHolder` to allocate a big enough buffer.
Then we use `UnsafeArrayWriter` to write primitive elements into the buffer.
After that, we create a `UnsafeArrayData` and point it to the buffer as its
backing data.
So we don't need to add such change into `BufferHolder` like this. Just a
new constructor is needed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
