Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16344#discussion_r93291042
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
 ---
    @@ -592,6 +629,59 @@ object GeneralizedLinearRegression extends 
DefaultParamsReadable[GeneralizedLine
       }
     
       /**
    +    * Tweedie exponential family distribution.
    +    * The default link for the Tweedie family is the log link.
    +    */
    +  private[regression] object Tweedie extends Family("tweedie") {
    +
    +    val defaultLink: Link = Log
    +
    +    var variancePower: Double = 1.5
    --- End diff --
    
    I think the Tweedie implementation needs to be able to access parameters of 
the GLM, to read off variancePower.
    
    As it is this is a global variable and two jobs would overwrite each 
others' values. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to