Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16344#discussion_r93420653
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
 ---
    @@ -397,14 +436,19 @@ object GeneralizedLinearRegression extends 
DefaultParamsReadable[GeneralizedLine
     
         /** Trim the fitted value so that it will be in valid range. */
         def project(mu: Double): Double = mu
    +
    +    /** Constant added to y = 0 for initialization or deviance to avoid 
numerical issues. */
    +    val delta: Double = 0.1
    --- End diff --
    
    This should be defined in an `object`; it's a static constant. The comment 
isn't quite accurate; it's not added, but it's a minimum.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to