Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r93290854
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -242,7 +275,7 @@ class GeneralizedLinearRegression @Since("2.0.0")
(@Since("2.0.0") override val
def setLinkPredictionCol(value: String): this.type =
set(linkPredictionCol, value)
override protected def train(dataset: Dataset[_]):
GeneralizedLinearRegressionModel = {
- val familyObj = Family.fromName($(family))
+ val familyObj = Family.fromName($(family), $(variancePower))
--- End diff --
I don't think we can do this either. variancePower is specific to one
family, not a property of all of them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
