Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16470#discussion_r94588767
  
    --- Diff: 
core/src/test/scala/org/apache/spark/deploy/history/FsHistoryProviderSuite.scala
 ---
    @@ -474,6 +475,48 @@ class FsHistoryProviderSuite extends SparkFunSuite 
with BeforeAndAfter with Matc
         }
       }
     
    +
    +  test("support history server ui admin acls") {
    +    val conf = createTestConf()
    +      .set("spark.history.ui.acls.enable", "true")
    +      .set("spark.history.ui.admin.acls", "user1,user2")
    +      .set("spark.history.ui.admin.acls.groups", "group1")
    +      .set("spark.user.groups.mapping", 
classOf[TestGroupsMappingProvider].getName)
    +
    +    val provider = new FsHistoryProvider(conf)
    +
    +    val log = newLogFile("app1", Some("attempt1"), inProgress = false)
    +    writeFile(log, true, None,
    +      SparkListenerApplicationStart("app1", Some("app1"), 
System.currentTimeMillis(),
    +        "test", Some("attempt1")),
    +      SparkListenerEnvironmentUpdate(Map(
    +        "Spark Properties" -> Seq(
    +          ("spark.admin.acls", "user"),
    +          ("spark.admin.acls.groups", "group")),
    --- End diff --
    
    this isn't really tested


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to