Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/16470#discussion_r94597101
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -253,10 +253,13 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
val uiAclsEnabled =
conf.getBoolean("spark.history.ui.acls.enable", false)
ui.getSecurityManager.setAcls(uiAclsEnabled)
// make sure to set admin acls before view acls so they are
properly picked up
-
ui.getSecurityManager.setAdminAcls(appListener.adminAcls.getOrElse(""))
- ui.getSecurityManager.setViewAcls(attempt.sparkUser,
- appListener.viewAcls.getOrElse(""))
-
ui.getSecurityManager.setAdminAclsGroups(appListener.adminAclsGroups.getOrElse(""))
+ val adminAcls = conf.get("spark.history.ui.admin.acls", "") +
"," +
--- End diff --
Also rather then reading from the conf on every application UI creation
lets move the history.ui config reads up to a class val, similar to
UPDATE_INTERVAL_S. It would also be nice to print off those values into the
log files at initial start up. If you don't mind could you do the same for
spark.history.ui.acls.enable. I know it was this way before your change but
would be nice to make consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
