Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/16470#discussion_r94589837
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -253,10 +253,13 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
val uiAclsEnabled =
conf.getBoolean("spark.history.ui.acls.enable", false)
ui.getSecurityManager.setAcls(uiAclsEnabled)
// make sure to set admin acls before view acls so they are
properly picked up
-
ui.getSecurityManager.setAdminAcls(appListener.adminAcls.getOrElse(""))
- ui.getSecurityManager.setViewAcls(attempt.sparkUser,
- appListener.viewAcls.getOrElse(""))
-
ui.getSecurityManager.setAdminAclsGroups(appListener.adminAclsGroups.getOrElse(""))
+ val adminAcls = conf.get("spark.history.ui.admin.acls", "") +
"," +
--- End diff --
it feels a bit odd that this could be have a blank value and then comma ie
" ,value", but setAdminAcls handles it so I guess its ok. Lets make sure to
add unit test for this scenario and that way if someone accidentally changes
that we will catch it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
