Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16516#discussion_r95679101
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -365,7 +365,7 @@ class LogisticRegression @Since("1.2.0") (
case None => histogram.length
}
- val isMultinomial = $(family) match {
+ val isMultinomial = $(family).toLowerCase match {
--- End diff --
maybe we need to have a different accessor that is consistently used on the
transform/estimator side internally to:
1.) change the value to lowercase 2.) trim any whitespace
Changing the setter might cause issues because then when users try to
validate that their parameters are set correctly they will see that they are
modified, which is unexpected. The case-insensitive compare should be done as
in this PR, but instead of calling toLowerCase everywhere explicitly we should
be accessing using some other method that normalizes the parameter internally
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
