Github user imatiach-msft commented on a diff in the pull request:
https://github.com/apache/spark/pull/16516#discussion_r95848454
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -91,8 +91,8 @@ private[classification] trait LogisticRegressionParams
extends ProbabilisticClas
@Since("2.1.0")
final val family: Param[String] = new Param(this, "family",
"The name of family which is a description of the label distribution
to be used in the " +
- s"model. Supported options: ${supportedFamilyNames.mkString(", ")}.",
- ParamValidators.inArray[String](supportedFamilyNames))
+ s"model (case-insensitive). Supported options:
${supportedFamilyNames.mkString(", ")}.",
--- End diff --
maybe we can add an additional string param validators class then to the
same params.scala file in ml folder? There should be a generic function and
the params.scala file seems to be the right place.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
