Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/16516#discussion_r95858814
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala
---
@@ -365,7 +365,7 @@ class LogisticRegression @Since("1.2.0") (
case None => histogram.length
}
- val isMultinomial = $(family) match {
+ val isMultinomial = $(family).toLowerCase match {
--- End diff --
@yanboliang is correct that there are other entrance points for setting and
getting Params. I agree it'd be nice to consolidate them, but that would be
quite a bit of work and lower priority than other tech debt we currently have,
IMO.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
