Github user yanboliang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r95991944
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -106,11 +148,20 @@ private[regression] trait
GeneralizedLinearRegressionBase extends PredictorParam
schema: StructType,
fitting: Boolean,
featuresDataType: DataType): StructType = {
- if (isDefined(link)) {
- require(supportedFamilyAndLinkPairs.contains(
- Family.fromName($(family)) -> Link.fromName($(link))),
"Generalized Linear Regression " +
- s"with ${$(family)} family does not support ${$(link)} link
function.")
+ if ($(family) == "tweedie") {
+ require(!isDefined(link), "The link function for the tweedie family
must be " +
+ "specified using linkPower, not link.")
+ } else {
+ require(!isDefined(linkPower), s"The link function for the
${$(family)} family " +
+ "must be specified using link, not linkPower.")
--- End diff --
Ditto,
```
if (isSet(linkPower)) {
logWarning("When family is not tweedie, use param link to specify
link function. " +
"Setting param linkPower will take no effect.")
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
