Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16344#discussion_r96061883
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -242,9 +316,9 @@ class GeneralizedLinearRegression @Since("2.0.0")
(@Since("2.0.0") override val
def setLinkPredictionCol(value: String): this.type =
set(linkPredictionCol, value)
override protected def train(dataset: Dataset[_]):
GeneralizedLinearRegressionModel = {
- val familyObj = Family.fromName($(family))
- val linkObj = if (isDefined(link)) {
- Link.fromName($(link))
+ val familyObj = Family.fromParams(this)
+ val linkObj = if (isDefined(link) || isDefined(linkPower)) {
+ Link.fromParams(this)
} else {
familyObj.defaultLink
}
--- End diff --
Makes sense. I created a companion object `FamilyAndLink` with a factory
method to construct desired `FamilyAndLink` objects from the input param map.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
