Github user yanboliang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16344#discussion_r95991458
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
 ---
    @@ -106,11 +148,20 @@ private[regression] trait 
GeneralizedLinearRegressionBase extends PredictorParam
           schema: StructType,
           fitting: Boolean,
           featuresDataType: DataType): StructType = {
    -    if (isDefined(link)) {
    -      require(supportedFamilyAndLinkPairs.contains(
    -        Family.fromName($(family)) -> Link.fromName($(link))), 
"Generalized Linear Regression " +
    -        s"with ${$(family)} family does not support ${$(link)} link 
function.")
    +    if ($(family) == "tweedie") {
    +      require(!isDefined(link), "The link function for the tweedie family 
must be " +
    +        "specified using linkPower, not link.")
    --- End diff --
    
    I don't think we should throw error if users set ```link``` when family is 
set as ```tweedie```, and a warning log should be okay, like
    ```
    if (isSet(link)) {
            logWarning("When family is tweedie, use param linkPower to specify 
link function. " +
              "Setting param link will take no effect.")
          }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to