Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16650#discussion_r97341837
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
    @@ -168,6 +169,21 @@ private[scheduler] class BlacklistTracker (
           if (newTotal >= MAX_FAILURES_PER_EXEC && 
!executorIdToBlacklistStatus.contains(exec)) {
             logInfo(s"Blacklisting executor id: $exec because it has 
$newTotal" +
               s" task failures in successful task sets")
    +        conf.get(config.BLACKLIST_ENABLED) match {
    --- End diff --
    
    shouldn't this just be using isBlacklistEnabled? and actually I don't think 
you will even get here if its disabled because it won't create the 
BlacklistTracker at all  so this shouldn't be needed


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to