Github user jsoltren commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r97625393
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -168,6 +169,21 @@ private[scheduler] class BlacklistTracker (
if (newTotal >= MAX_FAILURES_PER_EXEC &&
!executorIdToBlacklistStatus.contains(exec)) {
logInfo(s"Blacklisting executor id: $exec because it has
$newTotal" +
s" task failures in successful task sets")
+ conf.get(config.BLACKLIST_ENABLED) match {
--- End diff --
Yes indeed. The only non-test usage of BlacklistTracker.isBlacklistEnabled
is in the TaskSchedulerImpl's maybeCreateBlacklistTracker, which uses it as a
condition for creating the BlacklistTracker at all. So I agree, we don't need a
check here to see if the blacklist enabled, and if we did, isBlacklistEnabled
would be a better choice.
However, it is still meaningful to see if spark.blacklist.kill is set. I
believe this was just a typo: s/BLACKLIST_ENABLED/BLACKLIST_KILL_ENABLED/. This
is fixed in my latest commit.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
