Github user jsoltren commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r98090656
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/BlacklistTracker.scala ---
@@ -173,6 +174,24 @@ private[scheduler] class BlacklistTracker (
listenerBus.post(SparkListenerExecutorBlacklisted(now, exec,
newTotal))
executorIdToFailureList.remove(exec)
updateNextExpiryTime()
+ // Add executor to blacklist before attempting to kill it. This
allows a scheduler backend
+ // to immediately fail to allocate resources on this executor,
since killing could be
+ // asynchronous.
--- End diff --
We chatted offline and there were two misunderstandings (on my end) here.
One is that the order of killing and adding to the blacklist in
`BlacklistTracker` doesn't matter since that code is holding the taskScheduler
lock. The other is that `scheduler.nodeBlacklist.contains(executorId))` in
CoarseGrainedSchedulerBackend was wrong - it should be
`scheduler.nodeBlacklist.contains(hostname))`.
The next patch set that I upload will address both these issues.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
