Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16650#discussion_r98126123
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/CoarseGrainedSchedulerBackend.scala
 ---
    @@ -148,6 +153,14 @@ class CoarseGrainedSchedulerBackend(scheduler: 
TaskSchedulerImpl, val rpcEnv: Rp
             if (executorDataMap.contains(executorId)) {
               executorRef.send(RegisterExecutorFailed("Duplicate executor ID: 
" + executorId))
               context.reply(true)
    +        } else if (scheduler.nodeBlacklist != null &&
    +          scheduler.nodeBlacklist.contains(hostname)) {
    +          // If the cluster manager gives us an executor on a blacklisted 
node (because it
    +          // already started allocating those resources before we informed 
it of our blacklist,
    +          // or if it ignored our blacklist), then we reject that executor 
immediately.
    +          logInfo(s"Rejecting $executorId as it has been blacklisted.")
    +          executorRef.send(RegisterExecutorFailed("Executor is 
blacklisted: " + executorId))
    --- End diff --
    
    nit: use interpolation for consistency.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to