Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/16650#discussion_r98126533
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationClient.scala ---
@@ -54,11 +54,28 @@ private[spark] trait ExecutorAllocationClient {
/**
* Request that the cluster manager kill the specified executors.
+ *
+ * When asking the executor to be replaced, the executor loss is
considered a failure, and
+ * killed tasks that are running on the executor will count towards the
failure limits. If no
+ * replacement is being requested, then the tasks will not count towards
the limit.
+ *
+ * @param executorIds identifiers of executors to kill
+ * @param replace whether to replace the killed executors with new ones,
default false
+ * @param force whether to force kill busy executors, default false
* @return the ids of the executors acknowledged by the cluster manager
to be removed.
*/
- def killExecutors(executorIds: Seq[String]): Seq[String]
+ def killExecutors(
+ executorIds: Seq[String],
+ replace: Boolean = false,
+ force: Boolean = false): Seq[String]
/**
+ * Request that the cluster manager kill every executor on the specified
host.
+ * @return whether the request is acknowledged by the cluster manager.
+ */
+ def killExecutorsOnHost(host: String): Boolean
--- End diff --
Probably good to specify here what's the behavior regarding "force" and
"replace", since they're not arguments.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
