Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16744#discussion_r99713106
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -35,10 +36,65 @@ import
org.apache.spark.streaming.receiver.{BlockGenerator, BlockGeneratorListen
import org.apache.spark.util.Utils
private[kinesis]
-case class SerializableAWSCredentials(accessKeyId: String, secretKey:
String)
- extends AWSCredentials {
- override def getAWSAccessKeyId: String = accessKeyId
- override def getAWSSecretKey: String = secretKey
+case class SerializableKCLAuthProvider(
--- End diff --
Can we simplify this piece of code? There are too many options. Might I
suggest something like:
```scala
trait SerializableAWSAuthProvider extends Serializable {
def getProvider: AWSCredentialsProvider
}
case class BasicCredentialProvider(
accessKeyId: String,
secretKey: String) extends SerializableAWSAuthProvider {
def getProvider: ...
}
case class STSCredentialsProvider(
roleArn: String,
sessionName: String,
externalId: Option[String],
credentials: Option[BasicCredentialProvider]) ...
case object DefaultProvider extends DefaultAWSCredentialsProviderChain
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
