Github user brkyvz commented on a diff in the pull request:
https://github.com/apache/spark/pull/16744#discussion_r99899470
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -34,11 +35,56 @@ import org.apache.spark.streaming.Duration
import org.apache.spark.streaming.receiver.{BlockGenerator,
BlockGeneratorListener, Receiver}
import org.apache.spark.util.Utils
-private[kinesis]
-case class SerializableAWSCredentials(accessKeyId: String, secretKey:
String)
- extends AWSCredentials {
- override def getAWSAccessKeyId: String = accessKeyId
- override def getAWSSecretKey: String = secretKey
+/**
+ * Serializable interface providing a method executors can call to obtain
an
+ * AWSCredentialsProvider instance for authenticating to AWS services.
+ */
+private[kinesis] trait SerializableCredentialsProvider extends
Serializable {
--- End diff --
I would move these cred providers to its own file and make this a `sealed
trait`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
