Github user budde commented on a diff in the pull request:
https://github.com/apache/spark/pull/16744#discussion_r99718950
--- Diff:
external/kinesis-asl/src/main/scala/org/apache/spark/streaming/kinesis/KinesisReceiver.scala
---
@@ -35,10 +36,65 @@ import
org.apache.spark.streaming.receiver.{BlockGenerator, BlockGeneratorListen
import org.apache.spark.util.Utils
private[kinesis]
-case class SerializableAWSCredentials(accessKeyId: String, secretKey:
String)
- extends AWSCredentials {
- override def getAWSAccessKeyId: String = accessKeyId
- override def getAWSSecretKey: String = secretKey
+case class SerializableKCLAuthProvider(
--- End diff --
Was hoping for some feedback here. I think making this an interface with
split basic/STS implementations should work well. I'll give it a shot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
