Github user sethah commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r100901912
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -944,15 +981,27 @@ class GeneralizedLinearRegressionModel private[ml] (
private lazy val familyAndLink = FamilyAndLink(this)
override protected def predict(features: Vector): Double = {
- val eta = predictLink(features)
+ if (!isSetOffsetCol(this)) {
--- End diff --
Can we just make this `override protected def predict(features: Vector):
Double = predict(features, 0.0)` ?
This predict function is only potentially used by users who extended GLR
before this patch, when offset was always 0.0 anyway.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
