Github user actuaryzhang commented on a diff in the pull request:
https://github.com/apache/spark/pull/16699#discussion_r100975164
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/GeneralizedLinearRegression.scala
---
@@ -168,6 +179,7 @@ private[regression] trait
GeneralizedLinearRegressionBase extends PredictorParam
}
val newSchema = super.validateAndTransformSchema(schema, fitting,
featuresDataType)
+ if (isSetOffsetCol(this)) SchemaUtils.checkNumericType(schema,
$(offsetCol))
--- End diff --
@sethah This is a great point. The new commit does allow offset to be
missing when making predictions. I now check validity of offset only when it's
set and available in the prediction set. Otherwise, set offset to be zero.
Thanks for catching this and contributing the test.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
